S1939: Add support for record struct #5606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
changed the title
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
martin-strecker-sonarsource
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
|
Code coverage is to low because of the ILookup implementation. As this probably gets deleted anyway, I will only add tests if we keep it. |
martin-strecker-sonarsource
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
pavel-mikula-sonarsource
requested changes
May 3, 2022
analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantInheritanceList.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantInheritanceList.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantInheritanceList.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantInheritanceList.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantInheritanceList.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantInheritanceList.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Common/MultiValueDictionary.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Common/MultiValueDictionary.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
martin-strecker-sonarsource
force-pushed
the
Martin/RecordStruct_S1939
branch
from
d3075bc to
ac7e015
Compare
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
pavel-mikula-sonarsource
requested changes
May 4, 2022
analyzers/src/SonarAnalyzer.Common/Common/MultiValueDictionary.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Rules/RedundantInheritanceListTest.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantInheritanceList.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
pavel-mikula-sonarsource
requested changes
May 5, 2022
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a custom
ILookupimplementation . It replaces the MultiValueDictionary used here. There is nothing wrong with MultiValueDictionary and it is used in multiple other places too.ILookupis just better suited for the intent here. I implemented my ownILookupbecause theToLookupextension method would have introduced a big overhead.I don't think it is worth to keep my custom
Lookupimplementation, as it basically does the same as the existing MultiValueDictionary. I left it for the moment in case you see value in keeping it.